-
Notifications
You must be signed in to change notification settings - Fork 85
Conversation
Commits cherry-picked from @brodybits' PR #49 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since master branch now targets next major release please use cordova-common@3.
@brodybits There is no Also, if this PR is not pushed, then NPM audit will always show security risk until we do a major release for cordova-common. I would like to to have at least the audit resolved. Even if we are not releasing the major this minute. We still build nightlies which would show these risks, though it should not affect to the users' app. |
Since cordova-common@3.0.0-nightly versions are already published, I would suggest the following alternatives:
|
From the dev mailing list discussion, I believe it was decided to not use nightly builds. If this is correct can the PR now be accepted so we can fix at least the audit? And worry about the version bump at release time? |
Nothing here that could block a merge - if there is a better way to do things, this can be done in a new, additional PR anyway. |
Fine with me |
Platforms affected
osx
What does this PR do?
What testing has been done on this change?
npm test