This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Only copy platform node_modules when created by binary #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodycj
reviewed
Nov 8, 2018
| @@ -83,7 +83,7 @@ function copyScripts (projectPath) { | |||
| // Copy in the new ones. | |||
| var binDir = path.join(ROOT, 'bin'); | |||
| shell.cp('-r', srcScriptsDir, projectPath); | |||
| shell.cp('-r', path.join(ROOT, 'node_modules'), destScriptsDir); | |||
| if (options.copyPlatformNodeModules) shell.cp('-r', path.join(ROOT, 'node_modules'), destScriptsDir); | |||
There was a problem hiding this comment.
Suggested change
| if (options.copyPlatformNodeModules) shell.cp('-r', path.join(ROOT, 'node_modules'), destScriptsDir); | |
| if (options.copyPlatformNodeModules) | |
| shell.cp('-r', path.join(ROOT, 'node_modules'), destScriptsDir); |
(minor suggestion)
brodycj
approved these changes
Nov 8, 2018
dpogue
approved these changes
Nov 8, 2018
|
More Investigation Required |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
osx
What does this PR do?
When platform is installed though CLI,
cordova platform add osx, the copy node_modules step is no longer valid as dependencies are now at the project level.The step is required only when the create binary from the platform repo is called.
apache/cordova#32
What testing has been done on this change?