Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Local Testing #130

Merged
merged 11 commits into from
Apr 23, 2019
Merged

Improve Local Testing #130

merged 11 commits into from
Apr 23, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 23, 2019

Platforms affected

None

Motivation and Context

Local Test to Pass

Description

  • Quotation Wrap Target
  • Expand iOS Test Images
  • Cleanup getSimulatorModelId

Testing

  • npm run test-ios
  • Travis CI

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested a review from janpio April 23, 2019 13:24
package.json Outdated Show resolved Hide resolved
@janpio janpio merged commit 344438b into apache:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants