Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update(android): android 13 camera open Fixed #839

Closed
wants to merge 3 commits into from
Closed

Update(android): android 13 camera open Fixed #839

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c4277d
Update(android): android 13 camera open Fixed
rokanraja1 Jul 15, 2023
c1e5876
test failed adjust done
rokanraja1 Aug 21, 2023
36e37a0
that supported android 14 beta also changed
rokanraja1 Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 31 additions & 12 deletions src/android/CameraLauncher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1312,20 +1312,39 @@ public void onScanCompleted(String path, Uri uri) {
}

public void onRequestPermissionResult(int requestCode, String[] permissions,
int[] grantResults) {
for (int r : grantResults) {
if (r == PackageManager.PERMISSION_DENIED) {
this.callbackContext.sendPluginResult(new PluginResult(PluginResult.Status.ERROR, PERMISSION_DENIED_ERROR));
return;
int[] grantResults) throws JSONException {
String version = android.os.Build.VERSION.RELEASE;
if(Integer.parseInt(version) <= 13)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check may fail, you cannot assume that the user-visible will be number like or an integer.

Instead it should use Build.VERSION.SDK_INT

Which refers to the API level. Android 13 is API 33, which has a constant Build.VERSION_CODES.TIRAMISU

Can you also explain the rationale for adding in a version check for Android 13 and earlier? This is effectively selecting all devies that we support, excluding any newer android versions in the future. So that seems strange to me.

{
if(PermissionHelper.hasPermission(this, Manifest.permission.CAMERA)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: have you tested this line, because in my test in android 13 hasPermission is every time false, or you call a request to have permission, or remove this line(my android 13 worked without this if)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CAMERA permission is normally not required, but there is a caveat with the ACTION_MEDIA_CAPTURE API.

Note: if you app targets M and above and declares as using the Manifest.permission.CAMERA permission which is not granted, then attempting to use this action will result in a SecurityException.

Normally the CAMERA permission is only for gaining access to the camera hardware so it's not normally needed when intents. But if something, or someone adds the CAMERA permission to the app's manifest, then the CAMERA permission needs to be granted for the intent to work.

Copy link
Contributor

@breautek breautek Aug 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that being said, the condition seems to be doing <= android 13 check. But this caveat applies if your app targets M (API 23) or later, which is virtually all apps today. So I think this check will fail if you have an app that declares the CAMERA permission on the next Android version.

switch (requestCode) {
case TAKE_PIC_SEC:
takePicture(this.destType, this.encodingType);
break;
case SAVE_TO_ALBUM_SEC:
this.getImage(this.srcType, this.destType);
break;
}
}
else {
PermissionHelper.hasPermission(this, Manifest.permission.CAMERA);
}
}
switch (requestCode) {
case TAKE_PIC_SEC:
takePicture(this.destType, this.encodingType);
break;
case SAVE_TO_ALBUM_SEC:
this.getImage(this.srcType, this.destType);
break;
else{
for (int r : grantResults) {
if (r == PackageManager.PERMISSION_DENIED) {
this.callbackContext.sendPluginResult(new PluginResult(PluginResult.Status.ERROR, PERMISSION_DENIED_ERROR));
return;
}
}
switch (requestCode) {
case TAKE_PIC_SEC:
takePicture(this.destType, this.encodingType);
break;
case SAVE_TO_ALBUM_SEC:
this.getImage(this.srcType, this.destType);
break;
}
}
}

Expand Down