Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No description for "replace?" parameter #295

Closed
de-dan opened this issue Sep 10, 2018 · 4 comments · Fixed by #410
Closed

No description for "replace?" parameter #295

de-dan opened this issue Sep 10, 2018 · 4 comments · Fixed by #410
Labels

Comments

@de-dan
Copy link

de-dan commented Sep 10, 2018

While url, target and options are documented, there is no description/documentation for the optional replace parameter in the index.d.ts file (line 45). The function is:
open(url: string, target?: string, options?: string, replace?: boolean): InAppBrowser;

I'm curious whats replace about.

@janpio janpio added the support label Sep 10, 2018
@janpio
Copy link
Member

janpio commented Sep 10, 2018

From looking at the whole repo this seems to be something leftover in the TS definition: https://github.com/apache/cordova-plugin-inappbrowser/search?q=replace&unscoped_q=replace

@janpio
Copy link
Member

janpio commented Oct 2, 2018

Hey @timbru31, I just merged a PR about the typings from you - so you seem to know your way around them. Could you please take a look? Thanks.

@timbru31
Copy link
Member

I've looked through the documentation and code. No platform is using the fourth parameter replace. IMHO we should remove it. Is an Apache JIRA issue necessary?

@janpio
Copy link
Member

janpio commented Jan 29, 2019

No, we haven't updated the issue and PR templates properly. All on Github now, so go for it and adapt the templates as necessary 🚀

timbru31 added a commit to timbru31/cordova-plugin-inappbrowser that referenced this issue Jan 29, 2019
janpio pushed a commit that referenced this issue Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants