-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No description for "replace?" parameter #295
Comments
From looking at the whole repo this seems to be something leftover in the TS definition: https://github.com/apache/cordova-plugin-inappbrowser/search?q=replace&unscoped_q=replace |
Hey @timbru31, I just merged a PR about the typings from you - so you seem to know your way around them. Could you please take a look? Thanks. |
I've looked through the documentation and code. No platform is using the fourth parameter |
No, we haven't updated the issue and PR templates properly. All on Github now, so go for it and adapt the templates as necessary 🚀 |
While
url
,target
andoptions
are documented, there is no description/documentation for the optionalreplace
parameter in the index.d.ts file (line 45). The function is:open(url: string, target?: string, options?: string, replace?: boolean): InAppBrowser;
I'm curious whats
replace
about.The text was updated successfully, but these errors were encountered: