Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin doesn't compile on Xcode 10 #831

Closed
jcesarmobile opened this issue Dec 9, 2020 · 2 comments
Closed

plugin doesn't compile on Xcode 10 #831

jcesarmobile opened this issue Dec 9, 2020 · 2 comments
Labels
Milestone

Comments

@jcesarmobile
Copy link
Member

jcesarmobile commented Dec 9, 2020

The plugin engines are set to cordova-ios 4 or greater. Which I think supported Xcode 9 and greater, but latest changes on 4.1.0 of the plugin makes it not compile on Xcode 10 or older because it doesn't understand defaultWebpagePreferences

It can be easily be fixed by using #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 130000 macros around the code, but I've already merged a breaking change.

Should we revert the breaking change and do a patch release with the fix?

Also, we should be more aggressive bumping the engines to try to force people to always use the latest version of the platforms and also make more clear the Xcode version cordova-ios supports and drops support of. At the moment, we say cordova-ios 6 says it adds support for Xcode 11, but doesn't say it drops support of Xcode 10, despite Apple doesn't accept apps built with it, users can still complain if the code doesn't build there as we didn't say we don't support it anymore.

@brodycj
Copy link

brodycj commented Dec 9, 2020

I have added the bug label, and we should probably make the patch release if we want to be strictly "semver" compliant.

That said, I don't know how many people would be affected, and anyone affected could always pin the old version as a workaround. I suspect that time spent making the patch release could be better spent solving some other issues on Cordova.

Also, we should be more aggressive bumping the engines

+1

I would favor that we avoid supporting old Xcode versions that are no longer supported by Apple itself, unless they are needed for some other reason.

@jcesarmobile
Copy link
Member Author

closing as won't fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants