Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): add InAppBrowserStatusBarStyle 'darkcontent' configuration option #828

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

NiklasMerz
Copy link
Member

Platforms affected

iOS

Motivation and Context

If the IAB loads a page with a white background on a device with dark mode enabled the statusbar will be white with white content. This PR ads the config.xml to set statusbar content to dark to make it readable again for pages like this.

Description

#765 added the option to set the statusbar to light content. iOS 13 introduced a new dark content option and this PR adds that.

Testing

Manual test
No automatic tests

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

README.md Outdated Show resolved Hide resolved
Co-authored-by: Tim Brust <github@timbrust.de>
@jcesarmobile
Copy link
Member

We should be careful with the @available usage, the code inside it is not understand if using an older SDK to build than the version on the @available, which means, this code doesn't compile on Xcode 10 or older.

For this PR is not a big deal since we are planning a major release and can bump the engines to cordova-ios 6 instead of 5.1.0 as on my pending PR, but then noticed version 4.1.0 is already using @available with iOS 13 and fails to build.

I've reported the issue

@jcesarmobile jcesarmobile changed the title (ios): add statusbar 'darkcontent' feat(ios): add InAppBrowserStatusBarStyle 'darkcontent' configuration option Jan 20, 2021
@NiklasMerz NiklasMerz added this to the 5.0.0 milestone Jan 30, 2021
@NiklasMerz NiklasMerz merged commit 6b92084 into apache:master Feb 9, 2021
jorgnava pushed a commit to okode/cordova-plugin-inappbrowser that referenced this pull request Apr 27, 2021
… option (apache#828)



Co-authored-by: Tim Brust <github@timbrust.de>
jorgnava pushed a commit to okode/cordova-plugin-inappbrowser that referenced this pull request Apr 27, 2021
… option (apache#828)



Co-authored-by: Tim Brust <github@timbrust.de>
FE-Roger pushed a commit to hogangnono/cordova-plugin-inappbrowser that referenced this pull request Sep 27, 2021
… option (apache#828)



Co-authored-by: Tim Brust <github@timbrust.de>
jessyefuster pushed a commit to jessyefuster/cordova-plugin-inappbrowser that referenced this pull request Aug 16, 2023
… option (apache#828)



Co-authored-by: Tim Brust <github@timbrust.de>
pesi-hgc pushed a commit to pesi-hgc/cordova-plugin-inappbrowser-transparent that referenced this pull request Nov 3, 2023
… option (apache#828)



Co-authored-by: Tim Brust <github@timbrust.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants