Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect TypeScript typings #515

Merged
merged 5 commits into from
Apr 3, 2020
Merged

Fix incorrect TypeScript typings #515

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
852467e
fix #514
Aug 1, 2019
8066296
Merge remote-tracking branch 'upstream/master'
Feb 24, 2020
376c70f
Merge remote-tracking branch 'upstream/master'
Apr 3, 2020
d8a1c0e
Update based on conversation in #514
Apr 3, 2020
dddf696
Fixed whitespace
Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Copyright (c) Microsoft Open Technologies Inc
// Licensed under the MIT license.
// TypeScript Version: 2.3
type channel = "loadstart" | "loadstop" | "loaderror" | "exit" | "message";
type channel = "loadstart" | "loadstop" | "loaderror" | "exit" | "message" | "customscheme";

interface Window {
/**
Expand Down Expand Up @@ -40,6 +40,13 @@ interface InAppBrowser extends Window {
* passed an InAppBrowserEvent object as a parameter.
*/
addEventListener(type: channel, callback: InAppBrowserEventListenerOrEventListenerObject): void;
/**
* Adds a listener for an event from the InAppBrowser.
* @param type any custom event that might occur.
* @param callback the function that executes when the event fires. The function is
* passed an InAppBrowserEvent object as a parameter.
*/
addEventListener(type: string, callback: InAppBrowserEventListenerOrEventListenerObject): void;
// removeEventListener overloads
/**
* Removes a listener for an event from the InAppBrowser.
Expand Down