Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #528

Closed
wants to merge 1 commit into from
Closed

Update README.md #528

wants to merge 1 commit into from

Conversation

julian-lang
Copy link

Added alternative way to get window.open function back

Platforms affected

All

Motivation and Context

delete window.open as stated in Documentation does not bring back original function.
Especially useful, if running in browser platform.

Description

Added alternative Way in Documentation on how to get native window.open function back.

Testing

Implemented it in local Project -> can use window.open natively again.

Checklist

  • [ x ] I've run the tests to see all new and existing tests pass
  • [ x ] I added automated test coverage as appropriate for this change
  • [ x ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [ x ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • [ x ] I've updated the documentation if necessary

Added alternative way to get window.open function back
@NiklasMerz
Copy link
Member

Thank you for this PR, someone might find it useful!

Before merging this change we may need to think again about the statemen in README:

For backwards compatibility, this plugin also hooks window.open. However, the plugin-installed hook of window.open can have unintended side effects (especially if this plugin is included only as a dependency of another plugin). The hook of window.open will be removed in a future major release. Until the hook is removed from the plugin, apps can manually restore the default behaviour:

Do we still plan to remove this backwards compatibility?

@NiklasMerz
Copy link
Member

This is no longer needed since the overwrite has been removed in #600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants