Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: remove UIWebView #635

Merged
merged 1 commit into from
Mar 5, 2020
Merged

breaking: remove UIWebView #635

merged 1 commit into from
Mar 5, 2020

Conversation

jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented Mar 1, 2020 •
edited
Loading

Remove all UIWebView code and traces

  • Removes all traces of UIWebView from README
  • Removes all UIWebView code
  • Removes usage of CDVUserAgentUtil as it's being removed from cordova-ios and it's not really needed for WKWebView
  • Removes old cordova version code checks as it will only work on the next cordova-ios
  • Removes suppressesincrementalrendering and keyboarddisplayrequiresuseraction as they were UIWebView only

NiklasMerz
NiklasMerz approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@NiklasMerz NiklasMerz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me so far but I am no Objective-C expert.

Will do some tests in apps later.

dpa99c
dpa99c approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@dpa99c dpa99c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Tested and couldn't find any issues.

@NiklasMerz NiklasMerz mentioned this pull request Mar 5, 2020
Closed
@NiklasMerz NiklasMerz linked an issue Mar 5, 2020 that may be closed by this pull request
Depreciated API error from Apple #532
Closed
@NiklasMerz
Copy link
Member

I did some basic tests. Looks good to me 👍

@jcesarmobile jcesarmobile merged commit 6c55e61 into apache:master Mar 5, 2020
@jcesarmobile jcesarmobile deleted the delete-uiwebview branch March 5, 2020 14:51
@jcesarmobile
Copy link
Member Author

thanks for the reviews!

X2Style added a commit to X2Style/cordova-plugin-inappbrowser that referenced this pull request Mar 13, 2020
@X2Style
Merge pull request #1 from apache/master
42affc6 
breaking(ios): remove UIWebView (apache#635)
MaximBelov pushed a commit to MaximBelov/cordova-plugin-inappbrowser that referenced this pull request Mar 18, 2020
@jcesarmobile @MaximBelov
breaking(ios): remove UIWebView (apache#635)
1748769
lihuelg pushed a commit to lihuelg/cordova-plugin-inappbrowser that referenced this pull request Mar 19, 2020
@jcesarmobile @lihuelg
breaking(ios): remove UIWebView (apache#635)
f60f46b
expertanswerz pushed a commit to expertanswerz/cordova-plugin-inappbrowser that referenced this pull request Apr 9, 2020
@ChanchleshSuryawanshi
Merge branch 'master' into 3.2.x
54528fb 
* master:
  docs: replaces outdated transition and presentation style links (apache#662)
  chore: remove deprecated orientation methods (apache#666)
  Fix incorrect TypeScript typings (apache#515)
  [apacheGH-652] add check for openInSystem postNotification (apache#654)
  ci: updates Node.js versions (apache#659)
  chore(npm): improve ignore list (apache#658)
  fix(android): Reset lefttoright if not set (apache#442)
  [android] Correcting the documentation regarding lefttoright opt… (apache#648)
  (android) Added option to turn on/off fullscreen mode in Android (apache#634)
  Android apacheGH-470 InAppBrowser: java.lang.IllegalArgumentException (apache#616)
  breaking(ios): remove UIWebView (apache#635)
  chore(release): 3.2.1-dev
@tverilytt
Copy link

Will it be included in next version (3.3.0?)?

@timbru31
Copy link
Member

Yes, but only in 4.0.0, as this is a breaking change. No ETA though.

@tverilytt
Copy link

Thanks for that! To use this now then, one has to pull master branch, no npm install option yet?

@timbru31
Copy link
Member

You can always use the unsupported master branch via git:
cordova plugin add https://github.com/apache/cordova-plugin-inappbrowser.git

@timbru31 timbru31 mentioned this pull request Apr 14, 2020
Merged
@tverilytt
Copy link

@timbru31 Thanks a lot for the tip, thanks to it, App Store deprecation warning related to UIWebView is gone :-)

@DoctorsInTech
Copy link

DoctorsInTech commented May 7, 2020 •
edited
Loading

Hi Cordova team, my capacitor build is currently being rejected, I think due to the in-app browser still referencing UIWebView. How can I implement the master branch of inappbrowser into my capacitor project?

Nvm I have integrated it, any indication of when 4.0.0 is intended on being released?

Thanks!

@tverilytt
Copy link

@DoctorsInTech Hi! I put this in my package.json:
"cordova-plugin-inappbrowser": "git+https://github.com/apache/cordova-plugin-inappbrowser.git",
and this in my config.xml:

Cheers
-jo

@breautek
Copy link
Contributor

breautek commented May 7, 2020

We generally don't provide any concrete dates for releases due to the volunteer-based nature of the project.

I can confidently say it still may take a little while because I believe there are some PRs we want to include in the 4.0.0 release that still needs to be merged. Then we have to start Release Process which can take some time, especially if there are any rejections.

But you shouldn't need to use the unsupported dev version to deal with the UIWebView issue. #584 was landed in version 3.2.0 which makes the plugin respect the WKWebViewOnly flag, offered in cordova-ios@5.1.1.

@erisu erisu mentioned this pull request Jun 1, 2020
Closed
@brodycj brodycj mentioned this pull request Jun 3, 2020
Closed
3 tasks
@rahul-rajabhoj
Copy link

@DoctorsInTech Hi! I put this in my package.json:
"cordova-plugin-inappbrowser": "git+https://github.com/apache/cordova-plugin-inappbrowser.git",
and this in my config.xml:
Cheers
-jo

Can you please specify the change required in config.xml file

@NiklasMerz
Copy link
Member

Please check this post: https://cordova.apache.org/howto/2020/03/18/wkwebviewonly.html

@rahul-rajabhoj
Copy link

rahul-rajabhoj commented Jun 5, 2020 •
edited
Loading

Please check this post: https://cordova.apache.org/howto/2020/03/18/wkwebviewonly.html

I am using capacitor along with ionic which uses WKWebView by default. Still do I need to follow the mentioned steps ?

@NiklasMerz
Copy link
Member

We cannot give instructions for using this plugin with Capacitor. You need to ask there or try yourself.

@rahul-rajabhoj
Copy link

rahul-rajabhoj commented Jun 5, 2020 •
edited
Loading

Hi Cordova team, my capacitor build is currently being rejected, I think due to the in-app browser still referencing UIWebView. How can I implement the master branch of inappbrowser into my capacitor project?

Nvm I have integrated it, any indication of when 4.0.0 is intended on being released?

Thanks!

I am also using the InAppBrowser in capacitor app for Azure AD Auth. I followed the following steps to use master branch and the good news is that the app got accepted by AppStore.

  1. npm install git+https://github.com/apache/cordova-plugin-inappbrowser.git
  2. npm install @ionic-native/in-app-browser
  3. ionic cap sync

@rahul-rajabhoj
Copy link

We cannot give instructions for using this plugin with Capacitor. You need to ask there or try yourself.

Okay Thanks @NiklasMerz . I will use the mentioned steps for one of my ionic cordova application.

Augustine2359 pushed a commit to Augustine2359/cordova-plugin-inappbrowser that referenced this pull request Jul 2, 2020
Revert "breaking(ios): remove UIWebView (apache#635)"
3bf3436 
This reverts commit 6c55e61.
Augustine2359 pushed a commit to Augustine2359/cordova-plugin-inappbrowser that referenced this pull request Aug 5, 2020
Revert "Revert "breaking(ios): remove UIWebView (apache#635)""
4d9d88e 
This reverts commit 3bf3436.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisu erisu erisu approved these changes

@dpa99c dpa99c dpa99c approved these changes

@NiklasMerz NiklasMerz NiklasMerz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Depreciated API error from Apple
9 participants
@jcesarmobile @NiklasMerz @tverilytt @timbru31 @DoctorsInTech @breautek @rahul-rajabhoj @erisu @dpa99c