Added download event

[shaikh-amaan-fm]

Platforms affected

Android

Motivation and Context

This change enables, generation of a download event.

closes #311

Description

Whenever the InAppBrowser receives or locates to a url which leads in downloading a file, the callback assgined to the "download" event is called. The parameter passed to this callback is an object with the the follwing properties

• type it contains the String value "download" always
• url The url that leaded to the downloading of file. Basically, the download link of file
• userAgent User Agent of the webview
• contentDisposition If the url contains "content-disposition" header, then this property holds the value of that field else this field is empty
• contentLength If the link of the file allows to obtain file size then this property holds the file size else it contains int value 0
• mimetype The MIME type of the file

[breautek]

Thank you for your contribution.

I left a few comments but due to the nature of this PR, I would also invite you to join our dev mailing list for discussion on Cordova development. I'm personally hesitate to merge any new features that only supports a single platform, unless if there is a good reason for it.

[veelci]

@breautek Is there any chance of this getting merged in? I'd like to avoid forking this repo to enable file downloads on android.

[breautek]

@breautek Is there any chance of this getting merged in? I'd like to avoid forking this repo to enable file downloads on android.

I can't really guarantee it, but overall I think this PR is good. I invited Nik for a second pair of eyes since he frequently uses/maintains this plugin... and the inappbrowser isn't something I actually use in my own projects.

Assuming that he's okay with it, I'll then allocate some time to rebase the PR to get it merged. Unless if @shaikh-amaan-fm is still around and does that rebase first.

My concern back in 2020 about it being android only still applies, but it isn't really a deal breaker, imo.

[veelci]

Thank you for the quick response. This should resolve issue #311 .

[NiklasMerz]

I must admit I haven't worked on an app with the IAB plugin in a long time but the code looks good to me. I think we can merge it if someone gets to use it.

[breautek]

Thanks Nik, I should have some time tonight after my work day to spend some time rebasing, and it will give me a chance to actually test the code as well.

So the plan is to merge sometime later tonight.