feat(android, ios): add 5G support

[ZumelzuR]

Platforms affected

Motivation and Context

  Solve 5g detections for iOS and Android (the current state of the plugin classify as UKNOWN the 5g network)
 open issue -> https://github.com/apache/cordova-plugin-network-information/issues/125

closes #125

Description

 We added a a new listener for check if NR is available and using that, if is the case, detect the 5g.

Testing

    We tested on android simulator and a physical android 10 and iOS simulator

Checklist

• [ x ] I've run the tests to see all new and existing tests pass
• [ x] I added automated test coverage as appropriate for this change
• [x ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• [ x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• [x ] I've updated the documentation if necessary

[dev-jcb]

How do we get pull requests to get merged in master branch?

[almothafar]

Any news about when to release this fix

[breautek]

Thank you for your PR.

I've added some notes, if you have any questions feel free to ask.

Noting that due to the added dependency of androidx this will be considered a breaking change for the plugin. This isn't a bad thing, just simply a note for maintainers, where this plugin will require at least cordova-android@9 (with AndroidXEnabled preference enabled).

[ZumelzuR]

Thank, these days are a little problematic for me but I will check and resolve all as soon as possible

[ZumelzuR]

Sorry was impossible to me to do this changes before. I update all as you requested and tested in my local. If you have more feedback or changes to me add let me know

[breautek]

Thanks for making the requested changes.

One last thing, the package-lock change should also be reverted, if possible. package-lock updates are typically done in their own independent PRs. This way if we ever had to revert this PR in the future, the revert won't be touching the package-lock.

As for the code changes, I've had a glance over and everything looks ok to me. I've approved the test actions to run and hopefully I can find some time tomorrow night to give it a test in an emulator.

[ZumelzuR]

You are right. Sorry I didn't realized about the changes on the package-lock.json. I will do the revert now

[ZumelzuR]

what about this?

[breautek]

lgtm

[DavidWiesner]

@ZumelzuR On my iPhone 13 Pro networkInfo.currentRadioAccessTechnology is always nil. Strange enough another phone (with the same os version) this pointer is not nil. I found networkInfo.currentRadioAccessTechnology is deprecated and can be nil on ios >= 14.2. I`ve found this fix https://github.com/Tencent/Hippy/pull/1597/files. May you can try this and add this to your PR.

Edit: May you will use a more reactive form (with a nil check):

static NSString *radioAccessNameIn(CTTelephonyNetworkInfo *networkInfo) {
  if (@available(iOS 13.0, *)) {
    if (networkInfo.currentRadioAccessTechnology == nil && networkInfo.dataServiceIdentifier) {
        return [networkInfo.serviceCurrentRadioAccessTechnology objectForKey:networkInfo.dataServiceIdentifier]; 
    }
  }
  return networkInfo.currentRadioAccessTechnology;
}

[ZumelzuR]

@ZumelzuR On my iPhone 13 Pro networkInfo.currentRadioAccessTechnology is always nil. Strange enough another phone (with the same os version) this pointer is not nil. I found networkInfo.currentRadioAccessTechnology is deprecated and can be nil on ios >= 14.2. I`ve found this fix https://github.com/Tencent/Hippy/pull/1597/files. May you can try this and add this to your PR.

Edit: May you will use a more reactive form (with a nil check):

static NSString *radioAccessNameIn(CTTelephonyNetworkInfo *networkInfo) {
  if (@available(iOS 13.0, *)) {
    if (networkInfo.currentRadioAccessTechnology == nil && networkInfo.dataServiceIdentifier) {
        return [networkInfo.serviceCurrentRadioAccessTechnology objectForKey:networkInfo.dataServiceIdentifier]; 
    }
  }
  return networkInfo.currentRadioAccessTechnology;
}

Thank you, ok yes I will do some testing on my devices and come back with the fix and an update.

[ZumelzuR]

Done, I added the fixes at b65a783

[DavidWiesner]

I got an error

network-information/CDVConnection.m:63:94: expected ';' at end of declaration

[mdivya-symplr]

@ZumelzuR I see IOS Test suites are failing for this PR

[ZumelzuR]

For fix this I should try to simulate a 5g connection in a ios12 device and check if is working?

[erisu]

Just nitpick changes to cleanup the PR.

• Cordova uses a 4-space indention.

[ZumelzuR]

@breautek I review the commits and add the changes of @erisu

thanks

[ZumelzuR]

some update on this?

[ZumelzuR]

Can somebody run the test or merge finally this? @erisu @breautek

[breautek]

closed/re-opened the PR as the test results expired and wasn't available. Assuming that the tests passes I'll do one last row call and I'll merge if there are no objections in the next ~24 hours.

[breautek]

the preprocessor macro doesn't appear to be working as intended here cause iOS 13 tests is failing on this line due to CTRadioAccessTechnologyNRNSA not being available.

/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp-3401-5V69QdTKGZQj/platforms/ios/HelloCordova/Plugins/cordova-plugin-network-information/CDVConnection.m:89:76: error: use of undeclared identifier 'CTRadioAccessTechnologyNRNSA'
                        if ([currentRadioAccessTechnology  isEqualToString:CTRadioAccessTechnologyNRNSA]) {
                                                                           ^

[ZumelzuR]

@breautek this error not make much sense for me, I mean is in a block of code that if the version is iOS14 will try to access.

Also I read this error is related with the xcode

dcloudio/native-docs#30
https://stackoverflow.com/questions/71585983/use-of-undeclared-identifier-ctradioaccesstechnologynr

Any suggestions? I have the last version of xcode and I will try to run it in iOS 13 simulator and check if I can reproduce

[breautek]

I think this is also causing a syntax error...

var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmp-3401-5V69QdTKGZQj/platforms/ios/HelloCordova/Plugins/cordova-plugin-network-information/CDVConnection.m:113:1: error: extraneous closing brace ('}')
}