This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
CB-12189: Add support for WinMD and DLL combination #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 77.00% (diff: 100%)@@ master #219 diff @@
==========================================
Files 16 16
Lines 2204 2222 +18
Methods 412 415 +3
Messages 0 0
Branches 433 438 +5
==========================================
+ Hits 1680 1711 +31
+ Misses 524 511 -13
Partials 0 0
|
|
Documentation update: apache/cordova-docs#671 Note - this PR has own override for |
matrosov-nikita
changed the title
|
@daserge could you take a look please? |
daserge
reviewed
Dec 21, 2016
| @@ -115,6 +115,33 @@ function PluginInfo(dirname) { | |||
| var configFiles = parentGetConfigFiles(platform); | |||
| return processChanges(configFiles); | |||
| }; | |||
|
|
|||
| this.getFrameworks = function(platform) { | |||
| @@ -304,6 +309,47 @@ describe('windows project handler', function () { | |||
| xpath = 'Reference[@Include="dummy6"]/HintPath'; | |||
| validateInstalledProjects('framework', frameworks[5], xpath, ['windows', 'windows10', 'phone']); | |||
| }); | |||
|
|
|||
| it('with .winmd and .dll files', function() { | |||
There was a problem hiding this comment.
Does this spec check that dll files have been actually copied? (according to this)
matrosov-nikita
force-pushed
the
support-winmd-and-dll
branch
from
8671717
to
98a8ec2
Compare
|
@vladimir-kotikov, @daserge, updated. |
vladimir-kotikov
force-pushed
the
support-winmd-and-dll
branch
from
98a8ec2
to
110bf79
Compare
|
Rebased on top of master and force-pushed, will merge once tests pass |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
self
What does this PR do?
This PR adds support for .winmd and .dll combination.
What testing has been done on this change?
Auto-test
Checklist