Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove committed node_modules from platforms #6

Closed
6 tasks done
raphinesse opened this issue Sep 11, 2018 · 3 comments
Closed
6 tasks done

Remove committed node_modules from platforms #6

raphinesse opened this issue Sep 11, 2018 · 3 comments
Assignees
@raphinesse
Labels
enhancement New feature or request

Comments

@raphinesse
Copy link
Contributor

raphinesse commented Sep 11, 2018 •
edited by dpogue
Loading

We don't need them anymore since CLI installs all dependencies properly now. Not having to bundle dependencies vastly simplifies adding a new dependency if you need it for a feature.

Tooling and core plugins are not affected.

Task List
@raphinesse raphinesse self-assigned this Sep 11, 2018
@raphinesse raphinesse added the enhancement New feature or request label Sep 11, 2018
@janpio
Copy link
Member

janpio commented Sep 11, 2018

(Added "Cordova coho Release Process documentation" as task)

@erisu
Copy link
Member

erisu commented Sep 11, 2018

For apache/cordova-ios#388, conflicts needs to be resolved and should be OK for merging since I last reviewed it. Would like a second opinion.

@erisu
Copy link
Member

erisu commented Sep 11, 2018 •
edited
Loading

It seems apache/cordova-osx#49, covers removing the node_modules and many other smaller tasks.

  • Could the node_module and bundledDependencies removal be cherry-picked?
  • Is it ideal to break down this PR into smaller multiple PRs?

This was referenced Sep 11, 2018
Merged
Merged
Merged
Merged
Merged
@dpogue dpogue closed this as completed Sep 11, 2018
@raphinesse raphinesse mentioned this issue Sep 26, 2018
Closed
6 tasks
@erisu erisu mentioned this issue Mar 11, 2019
Closed
@GoldHatGamer GoldHatGamer mentioned this issue Jul 1, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raphinesse raphinesse

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@janpio @dpogue @raphinesse @erisu