Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14242 remove bundledDependencies and committed node_modules #388

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Aug 2, 2018

Platforms affected

iOS

What does this PR do?

See https://issues.apache.org/jira/browse/CB-14242:

  • remove bundledDependencies entry from package.json
  • completely remove committed node_modules
  • fix .gitignore to completely ignore node_modules

Suggested merge type

  • rebase or merge commit

I would personally favor rebase merge: would be much cleaner for limited number of commits.

Squash merge is not desired since one of the commits is extremely large.

What testing has been done on this change?

  • able to do cordova platform add brodybits/cordova-ios#cb-14242-remove-bundled-dependencies-and-node-modules on new Cordova project and run on iOS using Cordova CLI
  • check that npm test items pass on Travis CI

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@brodycj brodycj requested a review from erisu August 2, 2018 05:01
@codecov-io
Copy link

codecov-io commented Aug 2, 2018

Codecov Report

Merging #388 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   74.29%   74.29%           
=======================================
  Files          12       12           
  Lines        1564     1564           
=======================================
  Hits         1162     1162           
  Misses        402      402

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 004b830...32b079e. Read the comment docs.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears OK to me. The only thing that I noticed when looking at the diff between npm i with and without pre-checked in packages were a few sub deps upgraded.

The plist package was the only one that had a major update (1.2.0 -> 2.1.0), while the rest were minors or patches.

Seeing that the tests are passing, It shouldn't be an issue.

@dpogue dpogue merged commit ff1bcd0 into apache:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants