CB-14242 remove bundledDependencies and committed node_modules #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
See https://issues.apache.org/jira/browse/CB-14242:
bundledDependencies
entry frompackage.json
node_modules
.gitignore
to completely ignorenode_modules
Suggested merge type
I would personally favor rebase merge: would be much cleaner for limited number of commits.
Squash merge is not desired since one of the commits is extremely large.
What testing has been done on this change?
cordova platform add brodybits/cordova-ios#cb-14242-remove-bundled-dependencies-and-node-modules
on new Cordova project and run on iOS using Cordova CLInpm test
items pass on Travis CIChecklist
Added automated test coverage as appropriate for this change.