Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple build system improvements #200

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Multiple build system improvements #200

merged 1 commit into from
Mar 23, 2021

Conversation

wohali
Copy link
Member

@wohali wohali commented Mar 22, 2021

Overview

Docker builds were failing locally for a couple of reasons:

  • Cuda Ubuntu Arm64 and PPC64LE Image builds failing on VM with Buildkit Only moby/buildkit#1943 was causing buildx-based cross-arch builds to fail.
    • To fix, this PR replaces multiarch/qemu-user-static with tonistiigi/binfmt which is directly supported by a core Docker maintainer. It uninstalls all qemu emulators, then replaces them with Docker-supported qemu emulators.
  • Keyservers were timing out on builds
    • Added hkps://hkps.pool.sks-keyservers.net to the list of keyservers in all relevant Dockerfiles
    • Install gosu and tini directly from Debian now that it is officially packaged
      • This has the bonus side effect of making the Dockerfile easier to read and faster to build!
      • To get this working for 2.3.1 I had to bump that image to buster.

These additional cleanups were performed:

  • Removes junkfile md from root directory
  • Removes the obsolete 1.7.2* and 3.0.1 definitions. They will live on in git history for anyone who wants them.
  • Removes support for building ppc64le by default. This will be re-added once proper HW is re-added to the CI infra.

Testing recommendations

./build.sh buildx 3.1.1

(This will succeed but fail at the push part unless you have credentials to push to the apache Docker Hub org.)

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@wohali wohali merged commit 44dc516 into main Mar 23, 2021
@wohali wohali deleted the improve-build-process branch March 23, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants