Multiple build system improvements #200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Docker builds were failing locally for a couple of reasons:
buildx
-based cross-arch builds to fail.multiarch/qemu-user-static
withtonistiigi/binfmt
which is directly supported by a core Docker maintainer. It uninstalls all qemu emulators, then replaces them with Docker-supported qemu emulators.hkps://hkps.pool.sks-keyservers.net
to the list of keyservers in all relevant Dockerfilesgosu
andtini
directly from Debian now that it is officially packagedDockerfile
easier to read and faster to build!2.3.1
I had to bump that image tobuster
.These additional cleanups were performed:
md
from root directory1.7.2*
and3.0.1
definitions. They will live on in git history for anyone who wants them.ppc64le
by default. This will be re-added once proper HW is re-added to the CI infra.Testing recommendations
./build.sh buildx 3.1.1
(This will succeed but fail at the push part unless you have credentials to push to the
apache
Docker Hub org.)Checklist