Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better exception and message for table not found #851

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

mesejo
Copy link
Contributor

@mesejo mesejo commented Sep 2, 2024

Which issue does this PR close?

Closes #796.

What changes are included in this PR?

Change from the broad Exception to a specific KeyError exception.

Are there any user-facing changes?

Yes

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mesejo

@andygrove andygrove merged commit fe0738a into apache:main Sep 2, 2024
15 checks passed
allinux pushed a commit to allinux/datafusion-python that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: better exception when table doesn't exist
2 participants