Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for SAVEPOINT statement #438

Merged
merged 2 commits into from
Mar 13, 2022
Merged

add support for SAVEPOINT statement #438

merged 2 commits into from
Mar 13, 2022

Conversation

poonai
Copy link
Contributor

@poonai poonai commented Mar 12, 2022

This PR adds support for postgres SAVEPOINT statements.

ref: https://www.postgresql.org/docs/8.1/sql-savepoint.html

@coveralls
Copy link

coveralls commented Mar 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1974438120

  • 11 of 11 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 90.351%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 77.45%
Totals Coverage Status
Change from base Build 1974187335: 0.01%
Covered Lines: 7482
Relevant Lines: 8281
💛 - Coveralls

@poonai poonai mentioned this pull request Mar 12, 2022
Closed
alamb
alamb approved these changes Mar 12, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- thanks @poonai

Can you please resolve the conflict with this PR?

@poonai
Merge branch 'main' of github.com:sqlparser-rs/sqlparser-rs into poon…
6e7e167 
…ai/savepoint

Signed-off-by: poonai <rbalajis25@gmail.com>
@poonai
Copy link
Contributor Author

poonai commented Mar 12, 2022

@alamb done. Thanks for reviewing :)

I'm using sqlparser at my project https://github.com/poonai/inspektor

@alamb alamb merged commit 12a3e97 into apache:main Mar 13, 2022
@alamb
Copy link
Contributor

alamb commented Mar 13, 2022

Thanks again @poonai

@CDThomas CDThomas mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poonai @coveralls @alamb