Skip to content

Commit

Permalink
remove view override flag in benchmarks
Browse files Browse the repository at this point in the history
  • Loading branch information
alamb committed Sep 13, 2024
1 parent 29fb559 commit 2275216
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 18 deletions.
8 changes: 1 addition & 7 deletions benchmarks/src/clickbench.rs
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,7 @@ impl RunOpt {
None => queries.min_query_id()..=queries.max_query_id(),
};

let mut config = self.common.config();
config
.options_mut()
.execution
.parquet
.schema_force_view_types = self.common.force_view_types;

let config = self.common.config();
let ctx = SessionContext::new_with_config(config);
self.register_hits(&ctx).await?;

Expand Down
6 changes: 0 additions & 6 deletions benchmarks/src/tpch/run.rs
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,6 @@ impl RunOpt {
.config()
.with_collect_statistics(!self.disable_statistics);
config.options_mut().optimizer.prefer_hash_join = self.prefer_hash_join;
config
.options_mut()
.execution
.parquet
.schema_force_view_types = self.common.force_view_types;
let ctx = SessionContext::new_with_config(config);

// register tables
Expand Down Expand Up @@ -345,7 +340,6 @@ mod tests {
partitions: Some(2),
batch_size: 8192,
debug: false,
force_view_types: false,
};
let opt = RunOpt {
query: Some(query),
Expand Down
5 changes: 0 additions & 5 deletions benchmarks/src/util/options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,6 @@ pub struct CommonOpt {
/// Activate debug mode to see more details
#[structopt(short, long)]
pub debug: bool,

/// If true, will use StringView/BinaryViewArray instead of String/BinaryArray
/// when reading ParquetFiles
#[structopt(long)]
pub force_view_types: bool,
}

impl CommonOpt {
Expand Down

0 comments on commit 2275216

Please sign in to comment.