fix: fix string repeat for negative numbers (#10760)

* fix: fix string repeat for negative numbers * style: run cargo fmt
apache · Jun 3, 2024 · 59bfe77 · 59bfe77
1 parent 1db3263
commit 59bfe77
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/datafusion/functions/src/string/repeat.rs b/datafusion/functions/src/string/repeat.rs
@@ -88,7 +88,10 @@ fn repeat<T: OffsetSizeTrait>(args: &[ArrayRef]) -> Result<ArrayRef> {
         .iter()
         .zip(number_array.iter())
         .map(|(string, number)| match (string, number) {
-            (Some(string), Some(number)) => Some(string.repeat(number as usize)),
+            (Some(string), Some(number)) if number >= 0 => {
+                Some(string.repeat(number as usize))
+            }
+            (Some(_), Some(_)) => Some("".to_string()),
             _ => None,
         })
         .collect::<GenericStringArray<T>>();

diff --git a/datafusion/sqllogictest/test_files/expr.slt b/datafusion/sqllogictest/test_files/expr.slt
@@ -541,6 +541,11 @@ SELECT repeat('Pg', 4)
 ----
 PgPgPgPg
 
+query T
+SELECT repeat('Pg', -1)
+----
+(empty)
+
 query T
 SELECT repeat('Pg', CAST(NULL AS INT))
 ----