Minor: refactor ParquetExec roundtrip tests (#5260)

* Minor: refactor ParquetExec roundtrip tests * Apply suggestions from code review Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com> --------- Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
apache · Feb 13, 2023 · 9710d7c · 9710d7c
1 parent 00e60f1
commit 9710d7c
Show file tree

Hide file tree

Showing 2 changed files with 171 additions and 109 deletions.
diff --git a/datafusion/core/src/datasource/file_format/parquet.rs b/datafusion/core/src/datasource/file_format/parquet.rs
@@ -550,6 +550,12 @@ pub(crate) mod test_util {
     use parquet::file::properties::WriterProperties;
     use tempfile::NamedTempFile;
 
+    /// Writes `batches` to a temporary parquet file
+    ///
+    /// If multi_page is set to `true`, all batches are written into 
+    /// one temporary parquet file and the parquet file is written
+    /// with 2 rows per data page (used to test page filtering and
+    /// boundaries).
     pub async fn store_parquet(
         batches: Vec<RecordBatch>,
         multi_page: bool,