impl not for expr

datafusion/src/logical_plan/expr.rs

@@ -31,6 +31,7 @@ use arrow::{compute::can_cast_types, datatypes::DataType};
 use functions::{ReturnTypeFunction, ScalarFunctionImplementation, Signature};
 use std::collections::{HashMap, HashSet};
 use std::fmt;
+use std::ops::Not;
 use std::sync::Arc;
 
 /// A named reference to a qualified field in a schema.
@@ -568,9 +569,8 @@ impl Expr {
     }
 
     /// Return `!self`
-    #[allow(clippy::should_implement_trait)]
     pub fn not(self) -> Expr {
-        Expr::Not(Box::new(self))
+        !self
     }
 
     /// Calculate the modulus of two expressions.
@@ -915,6 +915,14 @@ impl Expr {
     }
 }
 
+impl Not for Expr {
+    type Output = Self;
+
+    fn not(self) -> Self::Output {
+        Expr::Not(Box::new(self))
+    }
+}
+
 #[allow(clippy::boxed_local)]
 fn rewrite_boxed<R>(boxed_expr: Box<Expr>, rewriter: &mut R) -> Result<Box<Expr>>
 where
@@ -1967,6 +1975,11 @@ mod tests {
         DFField::new(Some(relation), column, DataType::Int8, false)
     }
 
+    #[test]
+    fn test_not() {
+        assert_eq!(lit(1).not(), !lit(1));
+    }
+
     macro_rules! test_unary_scalar_expr {
         ($ENUM:ident, $FUNC:ident) => {{
             if let Expr::ScalarFunction { fun, args } = $FUNC(col("tableA.a")) {

datafusion/src/physical_optimizer/pruning.rs

@@ -483,7 +483,7 @@ fn build_single_column_expr(
         if is_not {
             // The only way we know a column couldn't match is if both the min and max are true
             // !(min && max)
-            Some((min.and(max)).not())
+            Some(!(min.and(max)))
         } else {
             // the only way we know a column couldn't match is if both the min and max are false
             // !(!min && !max) --> min || max