You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Our invariants are formally documented in https://github.com/apache/arrow-datafusion/blob/master/docs/specification/invariants.md, but it's not being fully enforced across the board. During the implementation of #55, I have found couple bugs in our existing code base that could have been prevented if check for invariants more aggressively during development and in CI.
Describe the solution you'd like
One thing we could do is to insert conditional compilation asserts for invariants in places that could break the invariants. For example:
add assert to compare logical plan schema before and after each optimizer run
add assert to compare fields between logical plan and physical plan after physical planing
add assert to make sure physical plan only deals with unqualified fields, for example: ParquetExec::try_from_path
These asserts should be turned of in production builds.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Our invariants are formally documented in https://github.com/apache/arrow-datafusion/blob/master/docs/specification/invariants.md, but it's not being fully enforced across the board. During the implementation of #55, I have found couple bugs in our existing code base that could have been prevented if check for invariants more aggressively during development and in CI.
Describe the solution you'd like
One thing we could do is to insert conditional compilation asserts for invariants in places that could break the invariants. For example:
ParquetExec::try_from_path
These asserts should be turned of in production builds.
The text was updated successfully, but these errors were encountered: