Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to sqlparser 0.22 #3278

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Aug 27, 2022

Which issue does this PR close?

N/A

Rationale for this change

Pick up these changes from sqlparser:

  • Support OVERLAY expressions
  • Support WITH TIMEZONE and WITHOUT TIMEZONE when parsing TIMESTAMP expressions
  • Add ability for dialects to override prefix, infix, and statement parsing

What changes are included in this PR?

Update

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner labels Aug 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3278 (903de2b) into master (90a0e7c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3278      +/-   ##
==========================================
- Coverage   85.90%   85.89%   -0.01%     
==========================================
  Files         294      294              
  Lines       53400    53401       +1     
==========================================
- Hits        45874    45870       -4     
- Misses       7526     7531       +5     
Impacted Files Coverage Δ
datafusion/sql/src/planner.rs 80.62% <0.00%> (-0.04%) ⬇️
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/core/src/physical_plan/metrics/value.rs 86.93% <0.00%> (-0.51%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 78.55% <0.00%> (-0.35%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dandandan Dandandan merged commit 873b071 into apache:master Aug 27, 2022
@Dandandan
Copy link
Contributor

Thanks @andygrove

@ursabot
Copy link

ursabot commented Aug 27, 2022

Benchmark runs are scheduled for baseline = b1db5ff and contender = 873b071. 873b071 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@avantgardnerio
Copy link
Contributor

avantgardnerio commented Aug 27, 2022

Commenting to link ticket #3255 , because I think now that we treat all timestamp without timezone as UTC, we should be explicit about that in datafusion before a user complains.

@waitingkuo
Copy link
Contributor

timestamp without timezone will be the same as timestamp, output Timestamp<Nano, None> ( if we align with postgresql)

do you mean that timetamp with timezone to produce Timestamp<Nano, "UTC"> ?

@avantgardnerio
Copy link
Contributor

I think we should keep timestamp without timezone evaluating to Timestamp<Nano, None>. However, I think we should modify DataFusion to ensure None always means UTC for now as described in #3255.

@andygrove andygrove added the api change Changes the API exposed to users of the crate label Sep 2, 2022
@andygrove andygrove deleted the sqlparser-0.22 branch January 27, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change Changes the API exposed to users of the crate core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants