Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate push_down_projection tests under optimize_projections #9978

Closed
Jefffrey opened this issue Apr 6, 2024 · 1 comment · Fixed by #10071
Closed

Consolidate push_down_projection tests under optimize_projections #9978

Jefffrey opened this issue Apr 6, 2024 · 1 comment · Fixed by #10071
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Jefffrey
Copy link
Contributor

Jefffrey commented Apr 6, 2024

Is your feature request related to a problem or challenge?

#8340 removed push_down_projection rules in favour of optimize_projections

Describe the solution you'd like

Move tests in push_down_projection.rs to optimize_projections.rs and remove the push_down_projection.rs file

Describe alternatives you've considered

No response

Additional context

No response

@Jefffrey Jefffrey added enhancement New feature or request good first issue Good for newcomers labels Apr 6, 2024
@kavirajk
Copy link
Contributor

take

kavirajk added a commit to kavirajk/datafusion that referenced this issue Apr 13, 2024
…ze_projections.rs`

Fixes: apache#9978

The PR apache#8340 removed `push_down_projections.rs` in favour of `optimize_projections.rs`. This PR moves the tests as well.

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
kavirajk added a commit to kavirajk/datafusion that referenced this issue Apr 14, 2024
…ze_projections.rs`

Fixes: apache#9978

The PR apache#8340 removed `push_down_projections.rs` in favour of `optimize_projections.rs`. This PR moves the tests as well.

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
alamb pushed a commit that referenced this issue Apr 15, 2024
…ze_projections.rs` (#10071)

* cleanup(tests): Move tests from `push_down_projections.rs` to `optimize_projections.rs`

Fixes: #9978

The PR #8340 removed `push_down_projections.rs` in favour of `optimize_projections.rs`. This PR moves the tests as well.

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>

* remove the file `push_down_projection.rs`

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>

* Fix method signatures that are broken by other PRs

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>

* remove `push_down_projections.rs` from `lib.rs`

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>

---------

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
2 participants