Improve coerce API so it does not need DFSchema #10331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 1, 2024
| @@ -258,7 +258,7 @@ pub fn physical_expr(schema: &Schema, expr: Expr) -> Result<Arc<dyn PhysicalExpr | |||
| ExprSimplifier::new(SimplifyContext::new(&props).with_schema(df_schema.clone())); | |||
|
|
|||
| // apply type coercion here to ensure types match | |||
| let expr = simplifier.coerce(expr, df_schema.clone())?; | |||
| let expr = simplifier.coerce(expr, &df_schema)?; | |||
There was a problem hiding this comment.
This shows the effect of this API change on users (add a &)
| // it manually. | ||
| // https://github.com/apache/datafusion/issues/3793 | ||
| pub fn coerce(&self, expr: Expr, schema: DFSchemaRef) -> Result<Expr> { | ||
| pub fn coerce(&self, expr: Expr, schema: &DFSchema) -> Result<Expr> { |
There was a problem hiding this comment.
This is the actual change (I don't think making it take SimplifyInfo is practical given how much coerce does)
|
Thank you for the review @jayzhan211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3793
Rationale for this change
&DFSchemarather than an ownedWhat changes are included in this PR?
Change
coerceAPI fromto
Are these changes tested?
By existing CI
Are there any user-facing changes?
The API to call coerce is slightly changed. Note I am in the process of adding a proper fully baked API in #10181