Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve CommonSubexprEliminate rule #10396

Merged
merged 6 commits into from
May 8, 2024
Merged

Fix and improve CommonSubexprEliminate rule #10396

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9dd9a2f
Revert "fix(9870): common expression elimination optimization, should…
peter-toth May 1, 2024
3303096
expr id should always contain the full expr structure, cleaner expr i…
peter-toth May 2, 2024
b84835c
move `Expr` from `expr_set`s to `affected_id`s
peter-toth May 2, 2024
aad9768
better naming, docs fixes
peter-toth May 2, 2024
ad1b6c1
introduce `CommonExprs` type alias, minor todo fix
peter-toth May 7, 2024
688c38d
add test
alamb May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions datafusion/sqllogictest/test_files/select.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1613,6 +1613,14 @@ select count(1) from v;
----
1

# Ensure CSE resolves columns correctly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this test but it still resolves the expr as 1 (not 3) 🤔

# should be 3, not 1
# https://github.com/apache/datafusion/issues/10413
query I
select a + b from (select 1 as a, 2 as b, 1 as "a + b");
----
1

# run below query without logical optimizations
statement ok
set datafusion.optimizer.max_passes=0;
Expand Down