Fix panic in array_agg(distinct) query #10526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
github-actions
bot
added
physical-expr
jayzhan211
changed the title
alamb
approved these changes
May 15, 2024
| states[0] | ||
| .as_list::<i32>() | ||
| .iter() | ||
| .flatten() |
There was a problem hiding this comment.
what does the flatten do? Discard Option?
| 3 1 | ||
|
|
||
| # It has only AggregateExec with FinalPartitioned mode, so `merge_batch` is used | ||
| # If the plan is changed, whether the `merge_batch` is used should be verified to ensure the test coverage |
There was a problem hiding this comment.
💯 for the explanatory comments about why this explain is here
| @@ -198,6 +198,73 @@ statement error This feature is not implemented: LIMIT not supported in ARRAY_AG | |||
| SELECT array_agg(c13 LIMIT 1) FROM aggregate_test_100 | |||
|
|
|||
|
|
|||
| # Test distinct aggregate function with merge batch | |||
There was a problem hiding this comment.
I ran the test without the changes in this PR and it panic'd as expected:
cargo test --test sqllogictests
...
thread 'tokio-runtime-worker' panicked at datafusion/physical-expr/src/aggregate/array_agg_distinct.rs:158:9:
assertion `left == right` failed: state array should only include 1 row!
left: 5
right: 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
demetribu
reviewed
May 15, 2024
| @@ -153,12 +153,11 @@ impl Accumulator for DistinctArrayAggAccumulator { | |||
| return Ok(()); | |||
| } | |||
|
|
|||
| let array = &states[0]; | |||
|
|
|||
| assert_eq!(array.len(), 1, "state array should only include 1 row!"); | |||
There was a problem hiding this comment.
Is it okay that we just delete the assertion?
There was a problem hiding this comment.
yes, because it is no longer true, this PR is dealing with the array that has len more than one
|
Thanks @alamb ! |
glebpom
pushed a commit
to glebpom/datafusion
that referenced
this pull request
May 22, 2024
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
DDtKey
pushed a commit
to DDtKey/arrow-datafusion
that referenced
this pull request
May 22, 2024
Signed-off-by: jayzhan211 <jayzhan211@gmail.com> (cherry picked from commit 626c6bc)
glebpom
pushed a commit
to glebpom/datafusion
that referenced
this pull request
May 22, 2024
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
DDtKey
pushed a commit
to DDtKey/arrow-datafusion
that referenced
this pull request
May 22, 2024
Signed-off-by: jayzhan211 <jayzhan211@gmail.com> (cherry picked from commit 626c6bc)
maxburke
pushed a commit
to urbanlogiq/arrow-datafusion
that referenced
this pull request
Jun 28, 2024
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10486 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?