Move overlay planning toExprPlanner
#11398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
approved these changes
Jul 10, 2024
| @@ -193,7 +193,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { | |||
| } | |||
| } | |||
|
|
|||
| not_impl_err!("Extract not supported by UserDefinedExtensionPlanners: {extract_args:?}") | |||
| not_impl_err!("Extract not supported by ExprPlanner: {extract_args:?}") | |||
There was a problem hiding this comment.
👍
Thank you -- this is a nice drive by cleanup
alamb
changed the title
ExprPlanner for sql_overlay_to_exproverlay planning toExprPlanner
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Jul 12, 2024
* move overlay to expr planner * typo
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* move overlay to expr planner * typo
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 17, 2024
* move overlay to expr planner * typo
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 18, 2024
* move overlay to expr planner * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11223
Rationale for this change
Part of #11207
What changes are included in this PR?
Are these changes tested?
Existing test cases
Are there any user-facing changes?
No