Minor: move SessionStateDefaults into its own module
#11566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @alamb, it looks nice. |
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Jul 23, 2024
* Minor: move `SessionStateDefaults` into its own module * Fix no default features
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jul 31, 2024
* Minor: move `SessionStateDefaults` into its own module * Fix no default features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11420
Rationale for this change
We are slowly moving towards separating the dependency of SessionState from the datafusion core crate. To do so we need to eventually remove the dependency of SessionState on the core crate.
@Omega359 separated the defaults from
SessionStatein #11403.SessionStateDefaultshas many of those dependencies on the coreWhat changes are included in this PR?
This PR moves the
SessionStateDefaultsstruct, which depend very much on things in th core, into its own module which gets us slightly closer to being able to move the defaults out of session state.Are these changes tested?
Existing CI
Are there any user-facing changes?
No (this code is not part of any release yet)