Rename RepartitionExec metric repart_time to repartition_time
#11703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Jul 29, 2024
comphead
reviewed
Jul 31, 2024
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
|
It seems people like this naming better, so I will merge it in. Thanks everyone for your comments and review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11702
Rationale for this change
As described on #11702, this naming is more consistent with other metrics. Thank you @findepi for pointing it out
What changes are included in this PR?
Rename RepartitionExec metric
repart_timetorepartition_timeAre these changes tested?
CI
Are there any user-facing changes?
The metric name is now different