Change name of MAX/MIN udaf to lowercase max/min #11795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
edmondop
force-pushed
the
issue-11779
branch
2 times, most recently
from
cdcda3f
to
eb92c73
Compare
github-actions
bot
added
the
documentation
jayzhan211
reviewed
Aug 4, 2024
| @@ -326,7 +326,7 @@ impl Default for Min { | |||
| impl Min { | |||
| pub fn new() -> Self { | |||
| Self { | |||
| aliases: vec!["min".to_string()], | |||
There was a problem hiding this comment.
We don't need uppercase alias.
To use uppercase alias the query is something like select "MAX"(a) from t;, which is uncommon.
jayzhan211
reviewed
Aug 4, 2024
| @@ -413,7 +413,7 @@ impl Default for Max { | |||
| impl Max { | |||
| pub fn new() -> Self { | |||
| Self { | |||
| aliases: vec!["max".to_string()], | |||
| aliases: vec!["MAX".to_string()], | |||
jayzhan211
reviewed
Aug 4, 2024
| @@ -92,7 +92,7 @@ pub struct Max { | |||
| impl Max { | |||
| pub fn new() -> Self { | |||
| Self { | |||
| aliases: vec!["max".to_owned()], | |||
| aliases: vec!["MAX".to_owned()], | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Addresses #11779 . Remove also dead code in moving_min_max