Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nested loop join code #11863

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

lewiszlw
Copy link
Member

@lewiszlw lewiszlw commented Aug 7, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

We could use ? to make code cleaner.

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lewiszlw
Can you please describe what exactly gets improved? is it just error handling?

@lewiszlw
Copy link
Member Author

lewiszlw commented Aug 8, 2024

Yes, less match pattern.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @lewiszlw the code looks more structured now

@lewiszlw lewiszlw merged commit 053795c into apache:main Aug 8, 2024
24 checks passed
@lewiszlw lewiszlw deleted the improve-nlj-code branch August 8, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants