Fix license header #12008
Merged
Fix license header #12008
+199
−186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
github-actions
bot
added
sql
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
waynexia
commented
Aug 15, 2024
Comment on lines
+1
to
+7
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at |
There was a problem hiding this comment.
Different line break style
Comment on lines
2
to
7
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at |
There was a problem hiding this comment.
Missing one line in the middle
Comment on lines
+1
to
5
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the |
There was a problem hiding this comment.
Missing lines at the begining.
Comment on lines
9
to
13
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // UnLt required by applicable law or agreed to in writing, | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY |
| @@ -6,7 +6,7 @@ | |||
| // "License"); you may not use this file except in compliance | |||
| // with the License. You may obtain a copy of the License at | |||
| // | |||
| //http://www.apache.org/licenses/LICENSE-2.0 | |||
| // http://www.apache.org/licenses/LICENSE-2.0 | |||
Comment on lines
15
to
17
| // specific language governing permissions and limitations | ||
| // under the License.language governing permissions and | ||
| // limitations under the License. | ||
| // under the License. | ||
|
|
There was a problem hiding this comment.
Redundant sentences at the end
test-utils/src/string_gen.rs
Outdated
Comment on lines
16
to
18
| // under the License. | ||
| // | ||
| // use arrow::array::{ArrayRef, GenericStringArray, OffsetSizeTrait, RecordBatch, UInt32Array}; | ||
|
|
||
| use crate::stagger_batch; |
There was a problem hiding this comment.
Remove a dead code by the way
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
|
Almost forgot this ticket... Thanks to that great remainder 🤣 Renew the context:
Please let me know if I missed anything 🙈 (and Sorry for the huge delay |
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
When preparing datafusion-contrib/datafusion-orc#121 I opened this repo to find some reference. But I saw a strange header on a random opened file
datafusion/optimizer/src/push_down_filter.rs🤣What changes are included in this PR?
Are these changes tested?
no need
Are there any user-facing changes?
no