Support protobuf encoding and decoding of UnnestExec
#12344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
joroKr21
force-pushed
the
unnest/serde
branch
from
6844c15
to
47c9041
Compare
joroKr21
force-pushed
the
unnest/serde
branch
from
47c9041
to
b0503ae
Compare
Dandandan
reviewed
Sep 6, 2024
| @@ -1345,3 +1349,30 @@ fn roundtrip_interleave() -> Result<()> { | |||
| let interleave = InterleaveExec::try_new(inputs)?; | |||
| roundtrip_test(Arc::new(interleave)) | |||
| } | |||
|
|
|||
| #[test] | |||
| fn roundtrip_unnest() -> Result<()> { | |||
alamb
changed the title
UnnestExec
|
🚀 -- thanks @joroKr21 and @Dandandan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12343
Rationale for this change
Completeness of
UnnestExecWhat changes are included in this PR?
UnnestExecNodeto protosUnnestExectoUnnestExecNodeUnnestExecfromUnnestExecNodeUnnestExecto enable the encodingAre these changes tested?
Yes, added a roundtrip test.
Are there any user-facing changes?
UnnestExec