Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated datafusion_physical_expr::functions module #12505

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Remove deprecated datafusion_physical_expr::functions module #12505

merged 1 commit into from
Sep 18, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Sep 17, 2024

Cleanup.

@github-actions github-actions bot added the physical-expr Physical Expressions label Sep 17, 2024
@findepi findepi mentioned this pull request Sep 17, 2024
Merged
@alamb
Copy link
Contributor

alamb commented Sep 17, 2024

Nice -- this was likely left over from when we ported functions. Very cool

alamb
alamb approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find -- thank you @findepi

@jayzhan211
Copy link
Contributor

I thought this was reserved for backward compatible, but I'm ok to remove it.

@alamb
Copy link
Contributor

alamb commented Sep 18, 2024

I thought this was reserved for backward compatible, but I'm ok to remove it.

I think the idea is that the only pub functions have been deprecated for around 6 months, which should have been enough time to allow people to migrate to using different APIs

@alamb
Copy link
Contributor

alamb commented Sep 18, 2024

Thanks @findepi @jayzhan211 and @lewiszlw

@alamb alamb merged commit 10436d5 into apache:main Sep 18, 2024
24 checks passed
@findepi findepi deleted the findepi/remove-deprecated-datafusion-physical-expr-functions-module-36b2eb branch September 20, 2024 14:44
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this pull request Oct 11, 2024
@Michael-J-Ward
fix: remove use of deprecated make_scalar_function
7bab0a3 
`make_scalar_function` has been deprecated since v36 [0].
It is being removed from the public api in v43 [1].

[0]: apache/datafusion#8878
[1]: apache/datafusion#12505
This was referenced Oct 11, 2024
Merged
Open
timsaucer pushed a commit to timsaucer/datafusion-python that referenced this pull request Oct 14, 2024
@Michael-J-Ward
fix: remove use of deprecated make_scalar_function (apache#906)
840b5de 
* fix: remove use of deprecated `make_scalar_function`

`make_scalar_function` has been deprecated since v36 [0].
It is being removed from the public api in v43 [1].

[0]: apache/datafusion#8878
[1]: apache/datafusion#12505

* remove use of `.unwrap()` from pyarrow_function_to_rust
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewiszlw lewiszlw lewiszlw approved these changes

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@findepi @alamb @jayzhan211 @lewiszlw