[minor] overload from_unixtime func to have optional timezone parameter #13130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
jonathanc-n
approved these changes
Oct 27, 2024
Omega359
reviewed
Oct 27, 2024
Omega359
reviewed
Oct 27, 2024
Omega359
reviewed
Oct 27, 2024
Omega359
reviewed
Oct 27, 2024
|
I can probably finish the rest of the issue in another pr after this is merged |
Co-authored-by: Bruce Ritchie <bruce.ritchie@veeva.com>
|
I took the liberty of merging this PR up from main to resolve a conflict |
alamb
reviewed
Nov 3, 2024
There was a problem hiding this comment.
Thanks @buraksenn -- I am marking this PR as draft as it is no longer waiting on review (and I am trying to clear the review queue)
I did merge again from main to fix the compile error
Thanks for the review. I've fixed the issue and added test cases to timestamps.slt. I'm converting it to Ready for review again |
berkaysynnada
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Not closes but discussed in #12892
Rationale for this change
from_unixtime is not aware of timezone so this PR makes it have optional timezone parameter
What changes are included in this PR?
code,test,doc change for overloaded from_unixtime
Are these changes tested?
yes added tests
Are there any user-facing changes?
yes