Extract CrossJoin, Repartition, Union in LogicalPlan #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liukun4515
force-pushed
the
datafusion-1304
branch
from
46ae3e5
to
a575c7a
Compare
alamb
changed the title
alamb
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Looks good to me, though the PR has some conflicts that need to be resolved before we can merge it.
Thank you @liukun4515 and @xudong963 for pushing this forward
After this #1311 pr merged, i will address the conflicts. |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1304
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?