-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scalar_functions.md
for CI
#13340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Nov 10, 2024
After some investigation, we can fix this issue through this modification. datafusion/datafusion/functions-nested/src/map.rs Lines 263 to 291 in c48f12d
.with_sql_example(
r#"
```sql
-- Using map function
SELECT MAP('type', 'test');
----
{type: test}
SELECT MAP(['POST', 'HEAD', 'PATCH'], [41, 33, null]);
----
{POST: 41, HEAD: 33, PATCH: }
SELECT MAP([[1,2], [3,4]], ['a', 'b']);
----
{[1, 2]: a, [3, 4]: b}
SELECT MAP { 'a': 1, 'b': 2 };
----
{a: 1, b: 2}
-- Using make_map function
SELECT MAKE_MAP(['POST', 'HEAD'], [41, 33]);
----
{POST: 41, HEAD: 33}
SELECT MAKE_MAP(['key1', 'key2'], ['value1', null]);
----
{key1: value1, key2: }
```"#,
) |
I also prefer this, it makes the sql example more consistent (no start with tab/spaces) |
github-actions
bot
removed
the
documentation
Improvements or additions to documentation
label
Nov 10, 2024
Weijun-H
approved these changes
Nov 10, 2024
Merged to get CI green |
jayzhan211
pushed a commit
to jayzhan211/datafusion
that referenced
this pull request
Nov 12, 2024
* fix format of document ci * remove the indent of mpa example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
I'm not sure why #13324 changed the format of the code scope in
scalar_functions.md
but it causes the CI for checking themd
file to fail.I found 2 PRs have been impacted:
bit_length
testing #13336clone_on_ref_ptr
clippy lint on core crate #13338What changes are included in this PR?
Reformat
scalar_functions.md
Are these changes tested?
Checked by CI
Are there any user-facing changes?
no