feat: Support complex interval via IntervalMonthDayNano #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datafusion
ovr
force-pushed
the
df-complex-intervals
branch
from
ff286ce
to
a5d066b
Compare
ovr
force-pushed
the
df-complex-intervals
branch
from
a5d066b
to
43b8591
Compare
alamb
approved these changes
Jan 20, 2022
| @@ -496,6 +498,24 @@ async fn test_interval_expressions() -> Result<()> { | |||
| "interval '2' year", | |||
| "2 years 0 mons 0 days 0 hours 0 mins 0.00 secs" | |||
| ); | |||
| // complex | |||
|
Thank you @ovr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1017.
Rationale for this change
DF didn't support complex intervals, because it was not possible before Arrow introduced MonthDayNano type for IntervalType
What changes are included in this PR?
Support for planning complex intervals from SQL, for example:
Are there any user-facing changes?
No breaking changes.