Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine match pattern related code #1650

Merged
merged 1 commit into from
Jan 23, 2022
Merged

refine match pattern related code #1650

merged 1 commit into from
Jan 23, 2022

Conversation

xudong963
Copy link
Member

Which issue does this PR close?

No

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the datafusion Changes in the datafusion crate label Jan 23, 2022
@xudong963
Copy link
Member Author

During I wrote #1649, I found we can refine the match-pattern related code to make it clearer.

alamb
alamb approved these changes Jan 23, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice cleanup; 👍 @xudong963

@houqp houqp merged commit 01b5244 into apache:master Jan 23, 2022
@xudong963 xudong963 deleted the refine_code branch January 23, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xudong963 @alamb @houqp