Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ballista] Docker files for ui #22

Merged
merged 3 commits into from
Apr 24, 2021
Merged

[Ballista] Docker files for ui #22

merged 3 commits into from
Apr 24, 2021

Conversation

msathis
Copy link
Contributor

@msathis msathis commented Apr 21, 2021 •
edited
Loading

Do we have docker-compose where we can setup the entire system? I searched but couldn't find it. If it is, I would like to include the ui deployment there.

@codecov-commenter
Copy link

Codecov Report

Merging #22 (88c5266) into master (c365a4f) will not change coverage.
The diff coverage is n/a.

❗ Current head 88c5266 differs from pull request most recent head c2f5e42. Consider uploading reports for the commit c2f5e42 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   70.41%   70.41%           
=======================================
  Files         123      123           
  Lines       21261    21261           
=======================================
  Hits        14970    14970           
  Misses       6291     6291

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c365a4f...c2f5e42. Read the comment docs.

@msathis msathis changed the title Docker files for ui [Ballista] Docker files for ui Apr 21, 2021
@andygrove
Copy link
Member

Do we have docker-compose where we can setup the entire system? I searched but couldn't find it. If it is, I would like to include the ui deployment there.

There is a docker compose yaml under the ballista benchmark but we might want to consider moving this to a higher level as we get Ballista more integrated into this repo.

@msathis
Copy link
Contributor Author

msathis commented Apr 22, 2021

@andygrove Hi, Can we merge this now or we want to wait for the integrated docker-compose setup to be in place?

andygrove
andygrove reviewed Apr 22, 2021
View reviewed changes
dev/build-ui.sh
# specific language governing permissions and limitations
# under the License.

BALLISTA_VERSION=0.4.2-SNAPSHOT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to fix in this PR but I filed for #32 for removing these hard-coded versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

@andygrove
Copy link
Member

@andygrove Hi, Can we merge this now or we want to wait for the integrated docker-compose setup to be in place?

I think we just need to wait on #29 to finish getting the process in place for the repo.

andygrove
andygrove approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msathis
Copy link
Contributor Author

msathis commented Apr 24, 2021

@andygrove Hi, I am going to work on #32 next. If we can merge this, i can fix all hard coded BALLISTA_VERSION at one go.

@andygrove
Copy link
Member

Closes #45

@andygrove andygrove linked an issue Apr 24, 2021 that may be closed by this pull request
Add Dockerfile for Ballista scheduler UI #45
Closed
@andygrove andygrove merged commit 3cb83fe into apache:master Apr 24, 2021
@houqp houqp added ballista enhancement New feature or request labels Jul 29, 2021
alamb pushed a commit that referenced this pull request Jul 23, 2024
@sgrebnov
Improve unparser MySQL compatibility (#11589)
65dd364 
* Configurable date field extraction style for unparsing (#21)

* Add support for IntervalStyle::MySQL (#18)

* Support alternate format for Int64 unparsing (SIGNED for MySQL) (#22)

* Alternate format support for Timestamp casting (DATETIME for MySQL) (#23)

* Improve

* Fix clippy and docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Dockerfile for Ballista scheduler UI
4 participants
@msathis @codecov-commenter @andygrove @houqp