Add Expr::InSubquery and Expr::ScalarSubquery
#2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
Expr::InSubquery and Expr::ScalarSubqueryExpr::InSubquery and Expr::ScalarSubquery
42 tasks
alamb
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Looking very nice @andygrove
All aboard the subquery 🚂 !
I had a few stylistic / corner case comments but nothing that can't be addressed after merge as a follow on PR
datafusion/expr/src/expr_schema.rs
Outdated
| Expr::IsNull(_) | ||
| | Expr::IsNotNull(_) | ||
| | Expr::Exists { .. } | ||
| | Expr::InSubquery { .. } => Ok(false), |
There was a problem hiding this comment.
I think aIN can be nullable if its exprs are nullable:
alamb=# select null IN (select * from a);
?column?
----------
(1 row)So maybe Expr::InSubquery should return expr.nullable(input_schema) too
| subquery, | ||
| negated, | ||
| } => Ok(Expr::InSubquery { | ||
| expr: Box::new(clone_with_replacement(&**nested_expr, replacement_fn)?), |
| | Expr::Exists(_) | ||
| | Expr::Exists { .. } | ||
| | Expr::InSubquery { .. } | ||
| | Expr::ScalarSubquery(_) |
There was a problem hiding this comment.
at some point it would be cool to be able to evaluate scalar subqueries at plan time, "but not now" 😆
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
alamb
approved these changes
Apr 26, 2022
datafusion/expr/src/expr.rs
Outdated
Comment on lines
461
to
471
| Expr::InSubquery { | ||
| expr, | ||
| subquery, | ||
| negated, | ||
| } => { | ||
| if *negated { | ||
| write!(f, "{:?} NOT IN ({:?})", expr, subquery) | ||
| } else { | ||
| write!(f, "{:?} IN ({:?})", expr, subquery) | ||
| } | ||
| } |
There was a problem hiding this comment.
The same negated: true / negated: false could be applied to Expr::InSubquery as was applied to Expr::Exists
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2248
Rationale for this change
Add
InSubqueryandScalarSubquerytoExpras a step towards supporting SQL queries that use these expressions.What changes are included in this PR?
InSubqueryandScalarSubquerytoExprAre there any user-facing changes?
Yes, API change