WIP: Remove ExecutionProps from OptimizerRule trait
#2602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynexia
reviewed
May 24, 2022
| @@ -1130,7 +1130,7 @@ impl SessionConfig { | |||
| /// done so during predicate pruning and expression simplification | |||
| #[derive(Clone)] | |||
| pub struct ExecutionProps { | |||
| pub(crate) query_execution_start_time: DateTime<Utc>, | |||
| pub(crate) query_execution_start_time: Arc<Mutex<DateTime<Utc>>>, | |||
There was a problem hiding this comment.
I think this mutex is not needed?
There was a problem hiding this comment.
Thanks. You are right, I have removed it.
andygrove
commented
May 24, 2022
| SessionState { | ||
| session_id, | ||
| optimizers: vec
andygrove
force-pushed
the
optimizer-remove-execution-props
branch
from
130e402
to
053c8a6
Compare
andygrove
changed the title
ExecutionProps from OptimizerRule traitExecutionProps from OptimizerRule trait
|
I'm moving this back to draft for now. The Perhaps we need to provide the optimizer rules with a trait for accessing certain system state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2599 and #2535
Rationale for this change
The logical optimizer rules should not depend on execution properties and only one of them currently does (SimplifyExpressions - which also depends on the physical query planner).
What changes are included in this PR?
ExecutionPropsfromOptimizerRuleexecution_propstoSimplifyExpressionsruleAre there any user-facing changes?
No
Does this PR break compatibility with Ballista?
No