MINOR: add optimizer struct #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwener
force-pushed
the
refactor_optimzer
branch
2 times, most recently
from
7afb925
to
77049a2
Compare
jackwener
force-pushed
the
refactor_optimzer
branch
from
77049a2
to
76f9703
Compare
andygrove
reviewed
May 25, 2022
| pub fn optimize<F>( | ||
| &self, | ||
| plan: &LogicalPlan, | ||
| execution_props: &mut ExecutionProps, |
There was a problem hiding this comment.
Not related to your changes but I am trying to get rid of the use of ExecutionProps here - #2614
andygrove
approved these changes
May 25, 2022
There was a problem hiding this comment.
Thanks @jackwener. This looks like a good change to me and helps towards #2599 as well
alamb
approved these changes
May 25, 2022
| @@ -1189,7 +1190,7 @@ pub struct SessionState { | |||
| /// Uuid for the session | |||
| pub session_id: String, | |||
| /// Responsible for optimizing a logical plan | |||
| pub optimizers: Vec<Arc<dyn OptimizerRule + Send + Sync>>, | |||
| pub optimizer: Optimizer, | |||
There was a problem hiding this comment.
I think this is a nice improvement 👍
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Aug 30, 2022
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Aug 31, 2022
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
What changes are included in this PR?
Add the
Optimizerstruct.Are there any user-facing changes?
None
Does this PR break compatibility with Ballista?
No