Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune unused dependencies from datafusion-proto #2651

Merged
merged 1 commit into from
May 30, 2022
Merged

Prune unused dependencies from datafusion-proto #2651

merged 1 commit into from
May 30, 2022

Conversation

tustvold
Copy link
Contributor

These were added in #2639 but don't appear to be being used

@tustvold tustvold requested a review from andygrove May 30, 2022 15:14
@github-actions github-actions bot added the datafusion Changes in the datafusion crate label May 30, 2022
andygrove
andygrove approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tustvold. I do remember adding these but I don't remember why now. I guess I subsequently made changes where they were no longer needed.

@tustvold tustvold merged commit 3a313c9 into apache:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

Assignees
No one assigned
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tustvold @andygrove