Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make binary operator formatting consistent between logical and physical plans #3331

Merged
merged 5 commits into from
Sep 4, 2022

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Part of #3330

Rationale for this change

Logical plans use the Operator Display trait and Physical plans use the Operator Debug trait, meaning we end up with * in the logical plan and Multiply in the physical plan. Sometimes we end up with a mix of both in the final schema.

What changes are included in this PR?

Physical plan now uses Display trait.

Are there any user-facing changes?

No

@github-actions github-actions bot added the core Core DataFusion crate label Sep 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #3331 (df3e45a) into master (786c319) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3331      +/-   ##
==========================================
- Coverage   85.47%   85.47%   -0.01%     
==========================================
  Files         294      294              
  Lines       54059    54059              
==========================================
- Hits        46209    46208       -1     
- Misses       7850     7851       +1     
Impacted Files Coverage Δ
datafusion/core/src/execution/context.rs 78.75% <ø> (ø)
datafusion/core/tests/sql/aggregates.rs 99.37% <ø> (ø)
datafusion/core/tests/sql/decimal.rs 100.00% <ø> (ø)
datafusion/core/tests/sql/expr.rs 99.87% <ø> (ø)
datafusion/core/tests/sql/functions.rs 100.00% <ø> (ø)
datafusion/core/tests/sql/select.rs 99.77% <ø> (ø)
datafusion/core/tests/sql/timestamp.rs 99.66% <ø> (ø)
datafusion/core/tests/sql/window.rs 95.87% <ø> (ø)
datafusion/core/src/physical_plan/planner.rs 77.39% <100.00%> (ø)
datafusion/expr/src/logical_plan/plan.rs 77.44% <0.00%> (-0.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @andygrove 👍

@alamb
Copy link
Contributor

alamb commented Sep 4, 2022

I took the liberty of merging this branch with master to rerun CI and avoid logical conflicts

@andygrove andygrove merged commit b175f9a into apache:master Sep 4, 2022
@ursabot
Copy link

ursabot commented Sep 4, 2022

Benchmark runs are scheduled for baseline = d7fa064 and contender = b175f9a. b175f9a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@andygrove andygrove deleted the binary-op-formatting branch January 27, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants