-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make binary operator formatting consistent between logical and physical plans #3331
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3331 +/- ##
==========================================
- Coverage 85.47% 85.47% -0.01%
==========================================
Files 294 294
Lines 54059 54059
==========================================
- Hits 46209 46208 -1
- Misses 7850 7851 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me -- thank you @andygrove 👍
I took the liberty of merging this branch with master to rerun CI and avoid logical conflicts |
Benchmark runs are scheduled for baseline = d7fa064 and contender = b175f9a. b175f9a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #3330
Rationale for this change
Logical plans use the
Operator
Display
trait and Physical plans use theOperator
Debug
trait, meaning we end up with*
in the logical plan andMultiply
in the physical plan. Sometimes we end up with a mix of both in the final schema.What changes are included in this PR?
Physical plan now uses
Display
trait.Are there any user-facing changes?
No