Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Sort the output of SHOW ALL by config name #3823

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 13, 2022

Rationale for this change

Noticed while working on #3822

The show all command added by @waitingkuo in #3455 is awesome!

When I do show all I am trying to verify the setting of a particular configuration option. As coded now, the output comes out in some random order (hash value I suspect):

Before:

❯ show all;
+-------------------------------------------------+---------+
| name                                            | setting |
+-------------------------------------------------+---------+
| datafusion.execution.coalesce_target_batch_size | 4096    |
| datafusion.optimizer.filter_null_join_keys      | false   |
| datafusion.explain.physical_plan_only           | false   |
| datafusion.explain.logical_plan_only            | false   |
| datafusion.execution.coalesce_batches           | true    |
| datafusion.execution.batch_size                 | 8192    |
| datafusion.optimizer.skip_failed_rules          | true    |
| datafusion.execution.time_zone                  | UTC     |
+-------------------------------------------------+---------+
11 rows in set. Query took 0.005 seconds.

After: 🤗

❯ show all;
+-------------------------------------------------+---------+
| name                                            | setting |
+-------------------------------------------------+---------+
| datafusion.execution.batch_size                 | 8192    |
| datafusion.execution.coalesce_batches           | true    |
| datafusion.execution.coalesce_target_batch_size | 4096    |
| datafusion.execution.time_zone                  | UTC     |
| datafusion.explain.logical_plan_only            | false   |
| datafusion.explain.physical_plan_only           | false   |
| datafusion.optimizer.filter_null_join_keys      | false   |
| datafusion.optimizer.skip_failed_rules          | true    |
+-------------------------------------------------+---------+

What changes are included in this PR?

Add ORDER BY clause and test

Are there any user-facing changes?

More helpful visibility into config options

@alamb alamb marked this pull request as ready for review October 13, 2022 16:27
@github-actions github-actions bot added core Core DataFusion crate sql SQL Planner labels Oct 13, 2022
@andygrove andygrove merged commit aa0ded7 into apache:master Oct 14, 2022
@ursabot
Copy link

ursabot commented Oct 14, 2022

Benchmark runs are scheduled for baseline = 87dd4ff and contender = aa0ded7. aa0ded7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/sort_config_options branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants