Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing functions to python #388

Merged
merged 1 commit into from
May 23, 2021
Merged

Conversation

jgoday
Copy link
Contributor

@jgoday jgoday commented May 22, 2021

Which issue does this PR close?

Closes #374.

Rationale for this change

Complete python functions from logical_plan.

What changes are included in this PR?

Export python functions from logical_plan:

  • array
  • ascii
  • sum
  • bit_length
  • btrim
  • character_length
  • chr
  • concat_ws
  • in_list
  • initcap
  • left
  • lower
  • lpad
  • ltrim
  • md5
  • octet_length
  • regexp_replace
  • repeat
  • replace
  • reverse
  • right
  • rpad
  • rtrim
  • sha224
  • sha256
  • sha384
  • sha512
  • split_part
  • starts_with
  • strpos
  • substr
  • to_hex
  • translate
  • trim
  • upper

Are there any user-facing changes?

Update or add python binding docs.

@jimexist
Copy link
Member

related #389

Copy link
Member

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @jgoday ! Looks great.

I do not think we need to test these: we have demonstrated that the logic works for the others, and these are essentially using the same implementation, both in DataFusion and in the wrapper.

@jorgecarleitao jorgecarleitao changed the title #374: Add missing functions to python Add missing functions to python May 23, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #388 (5d0a725) into master (db4f098) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   74.94%   74.94%           
=======================================
  Files         146      146           
  Lines       24314    24314           
=======================================
  Hits        18221    18221           
  Misses       6093     6093           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4f098...5d0a725. Read the comment docs.

Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@Dandandan Dandandan merged commit 9eca329 into apache:master May 23, 2021
@houqp houqp added enhancement New feature or request python labels Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing functions to python
6 participants