git-ignore datafusion/proto/src/generated/datafusion.rs
#4640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is intentionally checked in https://github.com/apache/arrow-datafusion/blob/master/datafusion/proto/proto/datafusion.proto as part of the story around not needing users to have protoc installed? It is gross, but see #3950 for more context If you're seeing a diff this would imply something is off with the version pins somewhere? |
|
I'm not talking about the |
|
Oh... I'm curious what is generating that, is it some artifact from before #3950 perhaps? I can't seem to generate such a file locally... |
|
I cannot reproduce this on current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
-
Rationale for this change
I was close to accidentally adding this file to my PRs so many times by now, let's just git-ignore it.
What changes are included in this PR?
New git-ignore rule.
Are these changes tested?
-
Are there any user-facing changes?
-